Can't get images in mysql database to display

twmprys · October 10th, 2008, 10:49 AM

I've inserted images into a database, but can't get them to display. I wonder if someone could help? All I get on the screen are question marks where the images should be.

This is the script:

Code:


			
<HTML> 
<BODY> 
<?php
$host='localhost';
$username='username';
$password='password';
$db='database';

mysql_connect($host,$username,$password) or die("Unable to connect to SQL server"); 
@mysql_select_db($db) or die("Unable to select database"); 
$result=mysql_query("SELECT * FROM images") or die("Can't Perform Query"); 
While($row=mysql_fetch_object($result)) { 
echo "<IMG SRC=\"SecondType.php3?PicNum=$row->PicNum\">"; 
} 
?> 
</BODY> 
</HTML>

Then there's another script on a separate page:

Code:


			
<?php 
mysql_connect($host,$username,$password) or die("Unable to connect to SQL server"); 
@mysql_select_db($db) or die("Unable to select database"); 
$result=mysql_query("SELECT * FROM Images WHERE PicNum=$PicNum") or die("Can't perform Query"); 
$row=mysql_fetch_object($result); 
Header( "Content-type: image/gif"); 
echo $row->Image; 
?>

Rob · October 10th, 2008, 12:57 PM

I would never actually store a binary file in a database...

Instead of physically storing the images in the database, store them on the filesystem and store the file location (path to the image) in the database.

Storing images in a DB creates a huge overhead and can potentially slow a site right down.

Storing just the path to the file will negate the need for an additional page to pull out the image as you could just reference it with a standard image tag. You will also not have to expose a possible point of system compromise by letting everyone know the location of an image handler which is geared up for database retrieval.

twmprys · October 10th, 2008, 01:11 PM

Yes, I've read arguments both ways about this. Nevertheless, these are only small images, and I'm trying to construct a very simple interface to enable the site owner to make limited updates to text and pictures on their site.

jrja · October 16th, 2008, 08:52 PM

images in a database - not a good idea

anyway, do you need to give the images sizes? getimagesize()

and here - don't you need to break the quotes and concatinate some of this:

echo "<IMG SRC=\"SecondType.php3?PicNum=$row->PicNum\">";

echo "<IMG SRC=\"SecondType.php3?PicNum=\"" . $row->$PicNum . "\">";

Accurax · October 17th, 2008, 04:34 PM

Quote:

Originally Posted by twmprys

Yes, I've read arguments both ways about this. Nevertheless, these are only small images, and I'm trying to construct a very simple interface to enable the site owner to make limited updates to text and pictures on their site.

Im suprised youve read anything supporting an image actually stored in a database.... unless its a desktop environment where DB overhead isnt an issue... and even then its not the best idea.

Allways store the path and simply upload the image to the relevant directory.

if your using php (i suspect you are) look into the GD Library... this is a series of php functions that allow you to resize, rename and generally edit imagess on the fly as its uploaded by the user... you can even add watermarks on the fly. it's pretty simple to use if you have a basic php understanding, and will give you exactly what your looking for.

I think the GD lib is actually included in php5 aswell .... but dont quote me on that.

Accurax · October 17th, 2008, 04:35 PM

Quote:

Originally Posted by jrja

echo "<IMG SRC=\"SecondType.php3?PicNum=\"" . $row->$PicNum . "\">";

exactly.... except... dont use CAPS in your tag names.... bad form !!