Comment form

jonbenitos · July 24th, 2006, 07:52 AM

Hi I have created a comments form in php, which is located at www.galaxywindows.co.uk/comments.php

However when i click submit the message isn't sent to my email, Does anyone know why this might be. Below is the code.

Part 1 - Comments.php

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
</head>
<body>
<?php
if(isset($_GET['posted'])) {
$to = 'jonbenitos@gmail.com'; //Email address to send it to
$fname = $_POST['fname'];
$lname = $_POST['lname'];
$email = $_POST['email'];
$message = $_POST['message'];
//This is the body of the email. You can modify it...
$body = 'Name: ' . $fname . ' ' . $lname . ' Email: ' . $email . ' Message: ' . $message;
//Send the message...
if(mail($to, 'Site Message', $body)) {
die('Success!');
} else {
die('Failure!');
}
}
?>
<form method="Post" action="http://www.galaxywindows.co.uk/comments.php?posted=yes">
<table>
<tr>
<td><label for="fname">First Name:</label></td>
<td><input type="text" name="fname" /></td>
</tr>
<tr>
<td><label for="lname">Last Name:</label></td>
<td><input type="text" name="lname" /></td>
</tr>
<tr>
<td><label for="email">E-Mail:</label></td>
<td><input type="text" name="email" /></td>
</tr>
<tr>
<td><label for"message">Message:</label></td>
<td><textarea name="message"></textarea></td>
</td>
<tr>
<td><input type="submit" /></td>
</tr>
</table>
</form>
</body>
</html>

Part 2 - Code.php

<?php
if(isset($_GET['posted'])) {
$to = 'jonbenitos@gmail.com';
$fname = $_POST['fname'];
$lname = $_POST['lname'];
$email = $_POST['email'];
$message = $_POST['message'];
//This is the body of the email. You can modify it...
$body = 'Name: ' . $fname . ' ' . $lname . ' Email: ' . $email . ' Message: ' . $message;
//Send the message...
if(mail($to, 'Site Message', $body)) {
die('Success!');
} else {
die('Failure!');
}
}
?>

ukgeoff · July 24th, 2006, 09:24 AM

There are several problems with your code.

The form method is defined as 'POST' but you have started your php checking with issset($_GET['posted']).

Remove the ?posted=yes' from your action url and give your submit button a name and a value. Both of which can be 'posted' if you like.

Your call to mail() does not include the forth variable. This can be a single thing or it can be a headers variable containing many elements that make up the header information.

At the very least it should have a 'From: ...' otherwise you risk the email getting treated like 'spam' and being filtered out.

jonbenitos · July 24th, 2006, 09:38 AM

could you post me the corrected code, I would be very grateful because I'm not sure how to get it working.Thanks alot

Regards

ScottR · July 24th, 2006, 07:16 PM

Maybe you should try to fix the code yourself. I doubt anyone is going to do it for you. But they will be happy to help you if you get stuck. I may be wrong but I don't understand why you have die twice in your code with one echoing success? I could be wrong but I personally have never seen that in a mail script. As far as I know die kills the script.

jpmitchell · July 24th, 2006, 08:06 PM

jonbenitos,

Here this may help: Simple Contact Form