problem calling function via onClick

Eagle · January 15th, 2007, 03:07 PM

This is my first post so I hope someone can help me out. I am very new to javascript and am having a problem calling a function using the onClick event linked to a button. I have produced the code below which generates a form with a series of boxes to complete. The user inputs a number at the first window.prompt which generates a form with the corresponding number of rows of fields. When the form has been completed I want to be able to call a function called assess_risk which currently only has a window.alert in it for testing purposes but will ultimately collect the data from each form field in a series of arrays which have been defined, and then used to perform some calculations. However when I click the button which calls the assess_risk function I get an error in IE. In Firefox 1.5 it also doesn't work and using the javascript console it says the error is assess_risk not defined.

I would really appreciate any help in understanding where I'm going wrong!

thanks

joe3dge · January 15th, 2007, 03:36 PM

that problem is an easy fix

you put:

Code:

document.write("<input type='button' value='Complete Assessment' onClick= assess_risk()>");

you need quotes around your 'assess_risk()' function call

you should have:

Code:

document.write("<input type='button' value='Complete Assessment' onClick='assess_risk()'>");

Eagle · January 15th, 2007, 03:47 PM

thanks for your quick reply but I had already tried it with and without the quotes around the function call and it makes no difference, still get same errors?

joe3dge · January 15th, 2007, 04:28 PM

ok i think i found the real problem this time
(although im pretty sure ur going to need those qutoes anyways)

the problem is that you are putting your "document.write()" commands inside a function in the <head> tags. because of this, the javascript compiler does not know where to put the text. on thing u could do, is create a <div> element and put the text inside that, with the .innerHTML property.

ok i dont know if i explaed that well, so im going to add my own version of the code SOON

joe3dge · January 15th, 2007, 04:37 PM

ok i got it working this time
i have the code attached

another adavantage of using the inner HTML property instead of the documwnt.write90 method is that the link stays on the page, so u can rerun the program multiple times.

i hope u enjoy ur now-working program

Eagle · January 15th, 2007, 06:41 PM

Thank you very much for your help, it's much appreciated. Now I can begin to write the assess_risk function in full.

I've alot to learn!!

greater · August 28th, 2009, 04:38 PM

I am having the same problem, but your text file with the solution is empty. Can you please re-post your fix?

Thanks!