Javascript code not working on Firefox?

hananah · August 11th, 2009, 05:57 PM

I have multiple rollovers and onclick commands using "function". They all work on Safari, but one of the functions doesn't work on Firefox.

-------------Here's the javascript:-------------
function list1() { if
(this.document.all.list1.style.display=="none")
(this.document.all.list1.style.display="block") ;
else (this.document.all.list1.style.display="none") ; }
--------------------------------------…

-------------and the HTML that calls this function-------------
<a href="javascript:chng('img1'); showOne2('photo1'); list1();">
Test Link</a>
----------------

To see the live page, here's my little tester spot i set up:
www.hanananah.com/brimin/index.php -- click "Design Live" - thats where I'm having the difficulty.

When you click anything of the list items (w/ the green arrows), content is supposed to show up under it, then disappear if u click it again. It works in Safari, but not in Firefox.

Any help is appreciated -- THANK YOU!

Captain Logical · August 28th, 2009, 11:41 PM

document.all is non-standard, use document.getElementById instead.
Instead of multiple functions, you should have only one function to which you pass a parameter:

Code:

function list( n ) 
{
 var elem =  document.getElementById("list" + n );
 elem.style.display =  (elem.style.display == 'block' ? 'none' : 'block' );
}
//to toggle "list1" use: list(1);

Also your links would be better using this format:

Code:

<a href="#" onclick="chng('img1'); showOne2('photo1'); list(1); return false">
Test Link</a>